Changeset 724

Timestamp:

06/22/08 05:09:39 (5 months ago)

Author:

francis

Message:

added receive_end_of_binary_data. Not really necessary but might come in handy someday.

Files:

• trunk/lib/protocols/linetext2.rb (modified) (2 diffs)
• trunk/tests/test_ltp2.rb (modified) (1 diff)

trunk/lib/protocols/linetext2.rb

@@ -85 +85 @@
-                                                if @lt2_textpos >= @lt2_textsize
-                                                        receive_binary_data @lt2_textbuffer.join
+                                                        receive_end_of_binary_data
-                                                        set_line_mode
-                                                end
@@ -140 +141 @@
-                                # no-op
-                        end
+
+                        # Stub. Should be subclassed by user code.
+                        # This is called when transitioning internally from text mode
+                        # back to line mode. Useful when client code doesn't want
+                        # to keep track of how much data it's received.
+                        def receive_end_of_binary_data
+                                # no-op
+                        end
-                end
-        end

trunk/tests/test_ltp2.rb

@@ -258 +258 @@
-        end
-
+
+
+        # Test an end-of-binary call. Arrange to receive binary data but don't bother counting it
+        # as it comes. Rely on getting receive_end_of_binary_data to signal the transition back to
+        # line mode.
+        # At the present time, this isn't strictly necessary with sized binary chunks because by
+        # definition we accumulate them and make exactly one call to receive_binary_data, but
+        # we may want to support a mode in the future that would break up large chunks into multiple
+        # calls.
+        class LazyBinary
+                include EM::Protocols::LineText2
+                attr_reader :data, :end
+                def initialize *args
+                        super
+                        @data = ""
+                        set_text_mode 1000
+                end
+                def receive_binary_data data
+                        # we expect to get all the data in one chunk, even in the byte-by-byte case,
+                        # because sized transfers by definition give us exactly one call to
+                        # #receive_binary_data.
+                        @data = data
+                end
+                def receive_end_of_binary_data
+                        @end = true
+                end
+        end
+        def test_receive_end_of_binary_data
+                testdata = "_" * 1000
+                a = LazyBinary.new
+                testdata.length.times {|i| a.receive_data( testdata[i...i+1] ) }
+                assert_equal( "_" * 1000, a.data )
+                assert( a.end )
+        end
-end
-