Changeset 573

Timestamp:

11/10/07 16:26:17 (1 year ago)

Author:

blackhedd

Message:

forced the port parameter of EM::Connection#send_datagram to be an Integer.

Files:

• version_0/ChangeLog (modified) (1 diff)
• version_0/lib/eventmachine.rb (modified) (1 diff)

version_0/ChangeLog

@@ -83 +83 @@
-        code. Suggested by Brian Candler.
-19Oct07: Set the SO_BROADCAST option automatically on all UDP sockets.
+10Nov07: Forced integer conversion of send_datagram's port parameter.
+Suggested by Matthieu Riou.

version_0/lib/eventmachine.rb

@@ -1394 +1394 @@
-        # size (typically about 1400 bytes). Some very restrictive WANs
-        # will either drop or truncate packets larger than about 500 bytes.
+        #--
+        # Added the Integer wrapper around the port parameter per suggestion by
+        # Matthieu Riou, after he passed a String and spent hours tearing his hair out.
-        #
-        def send_datagram data, recipient_address, recipient_port
-                data = data.to_s
-recipient_port
+Integer(recipient_port)
-        end
-