Changeset 300

Timestamp:

01/03/07 19:04:22 (2 years ago)

Author:

blackhedd

Message:

Fixed content-length bug in HTTP client

Files:

• version_0/lib/protocols/httpclient.rb (modified) (1 diff)
• version_0/Rakefile (modified) (1 diff)
• version_0/tests/test_httpclient.rb (modified) (1 diff)

version_0/lib/protocols/httpclient.rb

@@ -150 +150 @@
-          data = ary.last
-          if ary.first == ""
-
+
+
+
+
+
+
-          else
-            @headers << ary.first

version_0/Rakefile

@@ -197 +197 @@
-task :test_protocols => [ :test_hc, :test_ltp ]
-
+desc "Test HTTP client"
+task :test_httpclient do |t|
+  run_tests t, :extension, "test_httpclient.rb"
+end
+
-
-desc "Build everything"

version_0/tests/test_httpclient.rb

@@ -90 +90 @@
-
-
+  #-----------------------------------------
+
+  # Test a server that returns a page with a zero content-length.
+  # This caused an early version of the HTTP client not to generate a response,
+  # causing this test to hang. Observe, there was no problem with responses
+  # lacking a content-length, just when the content-length was zero.
+  #
+  class EmptyContent < EventMachine::Connection
+      def initialize *args
+          super
+      end
+      def receive_data data
+          send_data "HTTP/1.0 404 ...\r\nContent-length: 0\r\n\r\n"
+          close_connection_after_writing
+      end
+  end
+
+  def test_http_empty_content
+      ok = false
+      EventMachine.run {
+          EventMachine.start_server "127.0.0.1", 9701, EmptyContent
+          c = EventMachine::Protocols::HttpClient.send :request, :host => "127.0.0.1", :port => 9701
+          c.callback {|result|
+              ok = true
+              EventMachine.stop
+          }
+      }
+      assert ok
+  end
+
-end
-